remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

Blueprint for EFS #169

Closed aarcro closed 6 years ago

aarcro commented 6 years ago

Simple EFS implementation with tests. Making a MountTarget to actually use the thing needs to be integrated into other Blueprints.

russellballestrini commented 6 years ago

@aarcro looks like a great start. Your test is failing because the ecs.FileSystem derives from AWSObject. The AWSObject class expects the first argument to be a CamelCase "title".

References:

https://github.com/cloudtools/troposphere/blob/master/troposphere/efs.py#L5 https://github.com/cloudtools/troposphere/blob/master/troposphere/__init__.py#L91

russellballestrini commented 6 years ago

@aarcro, it looks like we already have a pending PR for something similar (https://github.com/remind101/stacker_blueprints/pull/129). I wonder if you and @danielkza could team up.

aarcro commented 6 years ago

Oh yeah, that looks better than mine. I searched issues, but not Pull requests for EFS stuff. I'll put my efforts there.