remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

Added SNS, SQS, and DynamoDB blueprints. #43

Closed jeffpierce closed 7 years ago

jeffpierce commented 7 years ago
jeffpierce commented 7 years ago

@phobologic @mhahn When you get a chance, give a look at this. @mhahn, I addressed the iteritems nit you had in the old PR as well.

mwildehahn commented 7 years ago

I think a lot of the prep and check methods could be moved to the new validator code that @phobologic added. that is pending a PR being merged into stacker though, might be worth waiting for it.

jeffpierce commented 7 years ago

@mhahn @phobologic Should be good to go now.

phobologic commented 7 years ago

Looking good! Thanks for doing this, @jeffpierce. Just a few minor comments, then I think we're good to go!

phobologic commented 7 years ago

👍

phobologic commented 7 years ago

Lets hold off on merging into master till stacker 0.8 is out (i'm pushing for tomorrow), then we can merge and update dependencies. Thanks @jeffpierce

mwildehahn commented 7 years ago

👍