Closed jeffpierce closed 7 years ago
@phobologic @mhahn When you get a chance, give a look at this. @mhahn, I addressed the iteritems nit you had in the old PR as well.
I think a lot of the prep
and check
methods could be moved to the new validator
code that @phobologic added. that is pending a PR being merged into stacker though, might be worth waiting for it.
@mhahn @phobologic Should be good to go now.
Looking good! Thanks for doing this, @jeffpierce. Just a few minor comments, then I think we're good to go!
👍
Lets hold off on merging into master till stacker 0.8 is out (i'm pushing for tomorrow), then we can merge and update dependencies. Thanks @jeffpierce
👍