search

remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

Fully convert firehose bp to variables #57

Closed phobologic closed 7 years ago

phobologic commented 7 years ago

This does away with the CFN types, and is backwards incompatible as it allowed me to move away from CommaDelimetedLists to plain lists, which will make the config easier to read/write.

phobologic commented 7 years ago

This is a PR for the release-1.0 branch BTW.

phobologic commented 7 years ago

This is a dangerous change until https://github.com/remind101/stacker/pull/254 is merged for the reasons listed in that PR. I've tested this with that PR's stacker code, and it successfully prevents any badness.

Running this blueprint against a stack definition that has been changed to use variables the correct way, using the same values that were used previously for the parameters, will only result in the adding of an Alias to the KMS Key, and adding a few Outputs.