search

remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

modify stacker_blueprints to use vpc nat gateway instead of nat instances #8

Closed cyommer closed 7 years ago

cyommer commented 8 years ago

Since cloudformation and troposphere support nat gateways now, should they be used instead of nat instances? I'm working on trying to modify vpc.py to support that, but I keep doing something wrong, so I don't have a pull request ready yet. Is this a direction in which you are moving, or are you planning on sticking with nat instances?

Also, thanks for doing some great work with this and empire!

phobologic commented 8 years ago

I'm actually really excited to get nat gateways going - but with that big of a change, I would first want to test what the failure case would be when upgrading (ie: the nat gateways get created, then the nat instances get deleted, etc). Anyway, I'm definitely moving that way - just want to make sure it's safe for everyone. That may mean having a new class, or something else (maybe a Parameter?)

Any ideas would be appreciated! Thanks!

cyommer commented 8 years ago

@phobologic Yeah, I get that. I was able to modify vpc.py to create the nat gateways and everything, and it worked as I'd hoped - it created the new eip and nat gateway first, updated the routing table and then it tore down the old nat instances after everything completed properly. So it updated my stack with the only interruption being the changing of the route table, which was almost instantaneous.

So, a couple things to think about:

I'm going to work on getting a parameterized version of that file going so that the switch to nat gateways isn't the default and won't happen automatically if you don't set use_nat_gateways = true (or something like that).

phobologic commented 7 years ago

Hey @cyommer - this was actually fixed back in April, so just getting around to cleaning things up. Not sure if you're still working on this, but if so please take a look at the update to the vpc blueprint. Thanks!