remind101 / stacker_blueprints

DEPRECATED - moved to:
https://github.com/cloudtools/stacker_blueprints
BSD 2-Clause "Simplified" License
39 stars 53 forks source link

Fix Elasticache template #90

Closed mmdriley closed 7 years ago

mmdriley commented 7 years ago

The Elasticache template hasn't worked since at least 66d49693.

That commit replaced all references to Conditions with references to Variables, except it missed the reference to HasInternalHostname.

It added a call to all() that never worked because its arguments weren't passed as a list.

Finally, it changed the type of the Subnets variable from EC2SubnetIdList to str. SubnetGroup.SubnetIds is a list: http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticache-subnetgroup.html#cfn-elasticache-subnetgroup-subnetids

phobologic commented 7 years ago

Thanks @mmdriley!