restrict temporal extent of industry equations

remindmodel / remind

REMIND - REgional Model of INvestments and Development

Other

93 stars 123 forks source link

restrict temporal extent of industry equations #1586

Closed 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed 4 months ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago

[x] Refactoring

Checklist:

[x] My code follows the coding etiquette
[ ] I performed a self-review of my own code
[x] I explained my changes within the PR, particularly in hard-to-understand areas
[x] I checked that the in-code documentation is up-to-date
[x] I adjusted the reporting in remind2 where it was needed
[x] I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
[x] All automated model tests pass (FAIL 0 in the output of make test)
[x] The changelog CHANGELOG.md has been updated correctly

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago

Let's do spring cleaning then. :tulip:

JakobBD commented 4 months ago

Damn it, shout out (and sorry) to @cchrisgong who did this a while ago in the pbs branch and I undid it because I thought there was a purpose for this.

Have you tested reporting and cs2? I vaguely remember some issues popping up there, but I may be mistaken again.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 4 months ago

Have you tested reporting and cs2? I vaguely remember some issues popping up there, but I may be mistaken again.

Only if for some reason the scripts access the flow equations outside of t … but even then it makes no difference whether they are not defined due to using t, or due to using ttot.val ge cm_startyear.