Closed tonnrueter closed 1 month ago
I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.
I think it'd be beneficial to have separate module realizations for different SCMs. I see your point here, however currently MAGICC is the de-facto standard for SCM integration in REMIND. Also there's more to come regarding climate assessment integration: I'm working on a PIAM pacakage remindClimateAssessment
that will interface REMIND with SCMs more broadly. Once we have that adding further realizations, e.g. with FAIR as SCM should be easy, yet it makes sense to me to keep them in dedicated climate module realization e.g. modules/15_climate/FAIR
I disagree with this one. The only thing that is really MAGICC7 specific in this realization is the parameter sets we currently use, but even that would take just new files, no changes in the interface, to use another OpenSCM-available model such as FAIR. RIght now, using FAIR instead of MAGICC would just be a matter of adding a flag to one of the Python calls. So I really think MAGICC7 should not be in the name of the new realization.
I think it'd be beneficial to have separate module realizations for different SCMs. I see your point here, however currently MAGICC is the de-facto standard for SCM integration in REMIND. Also there's more to come regarding climate assessment integration: I'm working on a PIAM pacakage
remindClimateAssessment
that will interface REMIND with SCMs more broadly. Once we have that adding further realizations, e.g. with FAIR as SCM should be easy, yet it makes sense to me to keep them in dedicated climate module realization e.g.modules/15_climate/FAIR
I see Gabriel's point. But that would also mean, that ar6
is no better name. Than the moduel should be caled climate_assessmant
or openSCM
, etc.
I agree, I'm in favor of openSCM
.
Purpose of this PR
The
15_climate
REMIND module now offers thear6
option. This runs a single scenario MAGICC7 climate emulation via IIASA'sclimate-assessment
to obtain the global mean temperature based on REMIND generated emission data. Previously we used the same simple climate model integration for AR6 Climate assessment on reportingType of change
(Make sure to delete from the Type-of-change list the items not relevant to your PR)
Checklist:
remind2
where it was neededforbiddenColumnNames
in readCheckScenarioConfig.R in case the PR leads to deprecated switchesFAIL 0
in the output ofmake test
)CHANGELOG.md
has been updated correctlyFurther information (optional):