remindmodel / remind

REMIND - REgional Model of INvestments and Development
Other
91 stars 123 forks source link

Selectively revert 1620: Remove SE from dimension from industry for performance #1659

Closed JakobBD closed 2 months ago

JakobBD commented 2 months ago

Purpose of this PR

Pull request #1620 (with the follow-up #1641 and #1648) introduces a secondary energy dimension in subsector-specific industry FE demand. It was designed to fix performance issues, but in fact convergence is better without it (see images below). This is due to a flat optimum in the new dimension, as it does not make a difference which SE ends up in which subsector.

This PR reverts the main changes in these PRs while keeping some others, like a price change limit between calibration iterations.

Credit for all the performance tests go to @0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q; Thanks for that!

Type of change

(Make sure to delete from the Type-of-change list the items not relevant to your PR)

Checklist:

Further information (optional):

H12: image EU21: image