add capacity factor for biogasc

tabeado commented 1 month ago

Purpose of this PR

According to the PR that introduces the technology biogasc, the technology is supposed to have the same capacity factor as the biogas tech without capture (pm_cf = 0.91). However, this factor does not show up in the fulldata.gdx and the deployment is 0 (see e.g. the recent AMT /p/projects/remind/modeltests/remind/output/SSP2EU-PkBudg650-AMT_2024-05-11_03.20.31/fulldata.gdx).

When the CF is added as in this PR, deployment is small but non-zero: /p/tmp/tabeado/sebiochar_AprRelease/remind/output/PB650-biogascCF_2024-05-08_12.09.32

Type of change

[x] Bug fix
[x] Minor change (default scenarios show only small differences)

Checklist:

[x] My code follows the coding etiquette
[x] I performed a self-review of my own code
[x] I explained my changes within the PR, particularly in hard-to-understand areas
[x] I checked that the in-code documentation is up-to-date
[ ] I adjusted the reporting in remind2 where it was needed
[ ] I adjusted forbiddenColumnNames in readCheckScenarioConfig.R in case the PR leads to deprecated switches
[x] All automated model tests pass (FAIL 0 in the output of make test)
[ ] The changelog CHANGELOG.md has been updated correctly

merfort commented 1 month ago

Good catch! Did you consider changing this assumption rather in mrremind to avoid having this number hard-coded in the REMIND code? This way, the value would show up in the input data file f_cf.cs3r and be read-in automatically, without changing anything else (I think).

tabeado commented 1 month ago

I thought about it, yes. But there are already all the other hard-coded capacity factors in the datainput file, so I thought hard coding it there would be fine. Also, I haven't ever touched mrremind. Would it be sufficient to just hard-code it in the file you linked? or anything else to be done?

robinhasse commented 1 month ago

Thank you very much @tabeado. This was clearly a bug in my original PR #859. Good that you fixed it!

merfort commented 1 month ago

I checked calcCapacityFactor.R and there values are also also just read-in from a CSV file with global values for all technologies. So we could simply adjust that file, though I am not sure, what is the best practice here. Adjusting the input data file will not be shown in any commit. @LaviniaBaumstark what would you suggest?

LaviniaBaumstark commented 1 month ago

I checked calcCapacityFactor.R and there values are also also just read-in from a CSV file with global values for all technologies. So we could simply adjust that file, though I am not sure, what is the best practice here. Adjusting the input data file will not be shown in any commit. @LaviniaBaumstark what would you suggest?

the best way woud be to fix it in mrremind. Ideale by adding a new CSV (copy of teh old with adjusted values) with a version number or date which than is read in in calcCapacityFactor.R. This ensures reproducability for old mrremind package versions as they would read in the old CSV file and all new would read in the fixed CSV file.

tabeado commented 1 month ago

Thanks a lot to @fbenke-pik for agreeing to implement this in mrremind!

remindmodel / remind