remindmodel / remind

REMIND - REgional Model of INvestments and Development
Other
91 stars 123 forks source link

fix non-fossil feedstock emi #1682

Closed 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q closed 1 month ago

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 month ago

Fixes non-fossil (biomass and synfuels) emissions from plastic waste incineration and non-plastics feedstock use having non-zero emissions in q_emiTeMkt, when they should be carbon-neutral.

Checklist:

Test runs

29738652  0:15  /p/tmp/pehl/Remind/output/foo2_2024-05-22_11.58.24
29738651  0:31  /p/tmp/pehl/Remind/output/foo1_2024-05-22_11.58.07
29738650  0:48  /p/tmp/pehl/Remind/output/SSP2EU-PkBudg500_2024-05-22_11.57.46
fschreyer commented 1 month ago

And I think this change requires changes in reportEmi as vm_emiTeMkt changes which is used for calculating Emi|CO2|Energy, while the emissions levels below that are calculated bottom-up. But we can tackle that after the test runs.

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 month ago

And I think this change requires changes in reportEmi as vm_emiTeMkt changes which is used for calculating Emi|CO2|Energy, while the emissions levels below that are calculated bottom-up. But we can tackle that after the test runs.

:point_right: pik-piam/remind2#602

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 month ago

:boom:

image

foo1 and foo2 have CO2 prices of 1000 and 1800 $/t in 2050, respectively. foo2 did not converge, though.

fschreyer commented 1 month ago

Nice!

PkBudg500 seems quite unaffected, so probably not too much changing for people with standard PkBudg scenarios, which is also good.

Can you share the PDF?

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 month ago

/p/tmp/pehl/Remind/compScen-2024-05-23_09.17.22-H12.pdf

0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q commented 1 month ago

Good to merge in my book. @fschreyer @JakobBD