yet another set of improvements to the emission market convergence algorithm and debugging information - Githubissues

remindmodel / remind

REMIND - REgional Model of INvestments and Development

Other

91 stars 123 forks source link

yet another set of improvements to the emission market convergence algorithm and debugging information #1707

Closed Renato-Rodrigues closed 1 hour ago

Renato-Rodrigues commented 2 weeks ago

Purpose of this PR

Avoid repeating calculation of the CO2 tax rescale factor in region groups.
Improving CO2 tax slope corner cases handling to be more reliable and speed up the convergence time.
Improving the report of the rescale factor calculation method for better debugging and future improvements.
Avoiding oscillatory behavior on CO2 tax rescaling by dampening the rescale factor if necessary.

Type of change

[x] New feature

Checklist:

[x] My code follows the coding etiquette
[x] I performed a self-review of my own code
[x] I explained my changes within the PR, particularly in hard-to-understand areas
[x] I checked that the in-code documentation is up-to-date
[x] All automated model tests pass (FAIL 0 in the output of make test)

Further information (optional):

Test runs are here: /p/projects/ecemf/REMIND/2040_scenarios/v08_2024_06_14_REMIND_3.3.1/output

Renato-Rodrigues commented 1 day ago

@robertpietzcker pinging for revision