remisharrock / c-programming-with-linux-MOOC-issues-tracker

7 stars 0 forks source link

new edx experience: process to change the codecast iframes #698

Open remisharrock opened 3 years ago

remisharrock commented 3 years ago
EllaHa commented 3 years ago

To keep track of where we are, please fill in the the spreedsheet, with updates https://docs.google.com/spreadsheets/d/1g9BjTF3aFaYvaGEaYd7VeBC8IYqOZD8kTg5tvDk2kdY/edit?usp=sharing

rserranosmith commented 3 years ago

I think that in the instructions we are supposed to change scrolling="yes" to scrolling-"no", and not the other way around. Am I right? Also, for hiding the overflow, is the correct syntax overflow:hidden or overflow="hidden"?

remisharrock commented 3 years ago

Thanks @rserranosmith my mistake, I modified it. For overflow, I think it's even style="overflow: hidden" I have to double check...

remisharrock commented 3 years ago

looking at https://stackoverflow.com/questions/10082155/remove-scrollbar-from-iframe I don't really understand the correct way of using overflow hidden... anybody any idea ?

remisharrock commented 3 years ago

I finally decided to remove the overflow:hidden parameter and updated the process accordingly...

rserranosmith commented 3 years ago

There was a small issue with the width of the code cast being too large, and cutting off a portion of the timeline. To fix this, we found that reducing the width from 100% to 95% seemed to fix the issue. Below is a summary of the changes to be made, as well as a picture for reference

scrolling="no"
height: 1100px;
width="95%"

Screen Shot 2021-05-27 at 10 11 45 AM

remisharrock commented 3 years ago

there are faulty ones after the modification and I'm opening new issues for them : https://github.com/remisharrock/c-programming-with-linux-MOOC-issues-tracker/issues/702 [update]: for me it's working, anbody can try again ?