search

remithomas / eslint-plugin-ban

Ban some methods and functions
ISC License
31 stars 4 forks source link

reduce visual impact #14

Closed FDIM closed 3 years ago

FDIM commented 3 years ago

I'm in the process of migrating to eslint from tslint, and this minor thing would be nice to take care of.

In the project we are banning calls to fit and fdescribe to prevent green build, this extension does this wonderfully.

Now the irk for me is this in vscode editor: image

tslint was simply highlighting the function name instead of entire block: image

Meaning you could still work normally, without seeing half/entire file being red. I can probably submit a PR if you are interested? Should be a small change to return different indexes ?

remithomas commented 3 years ago

Hello @FDIM, thanks for the report. Indeed this could be better, of course I'm interested, feel to create a MR 😄 thanks a lot