Closed bradgarropy closed 5 months ago
This PR adds GitHub Actions to run lint, format, and typecheck on the codebase.
lint
format
typecheck
I never know the best way to name these things. Which would y'all rather have?
Option 1 Three separate actions, one for lint, one for format, and one for typecheck.
The benefit here is that at a glance you know exactly what failed, but it increases the number of checks.
Option 2 Have a single action called pull request that executes all three commands.
pull request
It only exposes one check, but when something goes wrong you have to go into the pull request action and see what step failed.
This pull request currently implements Option 1.
The format step will pass after #9 is merged.
This PR adds GitHub Actions to run
lint
,format
, andtypecheck
on the codebase.I never know the best way to name these things. Which would y'all rather have?
Option 1 Three separate actions, one for
lint
, one forformat
, and one fortypecheck
.The benefit here is that at a glance you know exactly what failed, but it increases the number of checks.
Option 2 Have a single action called
pull request
that executes all three commands.It only exposes one check, but when something goes wrong you have to go into the
pull request
action and see what step failed.This pull request currently implements Option 1.