search

remix-pwa / monorepo

Remix PWA v4
https://remix-pwa.run
MIT License
105 stars 23 forks source link

Preserve source maps in transformations #241

Closed realrunner closed 2 months ago

realrunner commented 2 months ago

Rollup transformations should either generate source maps, return undefined if no transformation is necessary, or return an empty mappings object if mappings are not needed.

Should resolve: https://github.com/remix-pwa/monorepo/issues/167

See: https://rollupjs.org/plugin-development/#source-code-transformations

ShafSpecs commented 2 months ago

Thanks for the PR! Sorry for the late response, weirdly, I don't get emails from this repo anymore.

This PR is meant to solve an issue in the dev package, right? Could you please create a new commit and append it with: fix(dev): <commit-message>? That way, the CI would create a new release as soon as I merge :+1:

realrunner commented 2 months ago

I added the commit with the appropriate message. Thanks!

realrunner commented 2 months ago

Closing in favor of a squashed branch