search

remix-pwa / monorepo

Remix PWA v4
https://remix-pwa.run
MIT License
131 stars 25 forks source link

why are you talking about `CustomLogger`in the doc about `Offline` #261

Open arnaudambro opened 2 months ago

arnaudambro commented 2 months ago

on that page here: https://remix-pwa.run/docs/main/offline#custom-logger

I can see you talk about CustomLogger which has no relation with the Offline mode.

It makes me scared about your library: I have no doubt you did an code of good quality, but it feels overwhelmed sometimes, and this chapter comforts me in my thinking... Don't take it personally, but just as a user review ! :)

ShafSpecs commented 2 months ago

I can see you talk about CustomLogger which has no relation with the Offline mode.

It makes me scared about your library: I have no doubt you did an code of good quality, but it feels overwhelmed sometimes, and this chapter comforts me in my thinking... Don't take it personally, but just as a user review ! :)

Thanks for the feedback! I initially added it because I was using Kent Dodds stack and wanted to write every changes I made to the stack. In hindsight, it's looking like it might not have been the best idea. I would be making corrections ❤️