remix-run / grunge-stack

The Remix Stack for deploying to AWS with DynamoDB, authentication, testing, linting, formatting, etc.
https://remix.run/stacks
MIT License
438 stars 95 forks source link

feat: enable `v2_dev` flag #154

Closed MichaelDeBoey closed 1 year ago

MichaelDeBoey commented 1 year ago

@pcattori I keep getting the following error:

sandbox failed! Plugin error:
- Local env var conflicts with plugin:
- 'testing' variable 'NODE_ENV'
Error: Plugin error:
- Local env var conflicts with plugin:
- 'testing' variable 'NODE_ENV'

Maybe @lpsinger can point me into the right direction to fix this error as well 🤔

lpsinger commented 1 year ago

@pcattori I keep getting the following error:

sandbox failed! Plugin error:
- Local env var conflicts with plugin:
- 'testing' variable 'NODE_ENV'
Error: Plugin error:
- Local env var conflicts with plugin:
- 'testing' variable 'NODE_ENV'

Maybe @lpsinger can point me into the right direction to fix this error as well 🤔

Do you have a .env or a preferences.arc file that defines NODE_ENV? If so, remove it.

MichaelDeBoey commented 1 year ago

@lpsinger it was indeed in the .env file

The Arc template is talking about needing to create a a preferences.arc file in the root with the following contents:

@sandbox
livereload false

# NODE_ENV development is required when running the dev server
@env
testing
  NODE_ENV development

I guess this is not true then? 🤔

MichaelDeBoey commented 1 year ago

@pcattori The app is running, but it seems like I'm still missing something as HMR isn't working yet, it's doing a full page refresh

lpsinger commented 1 year ago

@lpsinger it was indeed in the .env file

The Arc template is talking about needing to create a a preferences.arc file in the root with the following contents:

@sandbox
livereload false

# NODE_ENV development is required when running the dev server
@env
testing
  NODE_ENV development

I guess this is not true then? 🤔

Oops! I didn't see those. My recent PRs made those instructions unnecessary. See https://github.com/remix-run/remix/pull/6796.

pcattori commented 1 year ago

Superceded by #164