feat: remove block() API

remix-run / history

Manage session history with JavaScript

MIT License

8.3k stars 960 forks source link

Closed brophdawg11 closed 2 years ago

brophdawg11 commented 2 years ago

Re-implements selective portions of #932 on top of the latest dev (post-prettier update) (does not remove action logic).

Removes the block() API
Removes associated tests for the block() api
Removes index logic from createBrowserHistory/createHashHistory as it was only used for block()

BREAKING CHANGE: The removal of history.block() will be a breaking change in history@6

mjackson commented 2 years ago

Thanks for doing this exploratory work, @brophdawg11. I'm going to close this and we'll follow up in the router repo. 👍

sdlbp commented 10 months ago

Why is this API being deleted? What factors were considered?