search

remix-run / history

Manage session history with JavaScript
MIT License
8.29k stars 961 forks source link

set initial memory history key to "default" #951

Open fmauquie opened 2 years ago

fmauquie commented 2 years ago

Documentation states that the initial entry always has key "default". However on memory history this is not the case.

We check that the key is "default" to set a default behavior when the user clicks a "back" button to go back to home, but arrived at the page from a direct link. This works perfectly in the browser, but failed in the test because the key was not "default" on MemoryRouter.

Nantris commented 2 years ago

I hope this could get merged soon. There are various, now rather long-standing, but extremely simple issues with MemoryHistory which don't seem to be moving forward, which makes upgrading to React Router 6 impossible, which breaks React.StrictMode. It's a cascade of consequences from like eight lines of missing code between this issue and #939.