remix-run / indie-stack

The Remix Stack for deploying to Fly with SQLite, authentication, testing, linting, formatting, etc.
https://remix.run/stacks
MIT License
1.13k stars 315 forks source link

bun breaks deploy #277

Closed justin-hackin closed 7 months ago

justin-hackin commented 7 months ago

Have you experienced this bug with the latest version of the template?

Yes

Steps to Reproduce

just run bun i in a fresh template derivation and push it out, you will see the action fail, complaining about lockfile:

#10 [production-deps 3/4] ADD package.json package-lock.json .npmrc ./
#10 ERROR: failed to calculate checksum of [REDACTED]: "/package-lock.json": not found

#11 [deps 2/3] ADD package.json package-lock.json .npmrc ./
#11 ERROR: failed to calculate checksum of  [REDACTED]: "/package-lock.json": not found
------
 > [deps 2/3] ADD package.json package-lock.json .npmrc ./:
------
------
 > [production-deps 3/4] ADD package.json package-lock.json .npmrc ./:
------
Error: failed to fetch an image or build from source: error building: failed to solve: failed to compute cache key: failed to calculate checksum of [REDACTED]: "/package-lock.json": not found
Error: Process completed with exit code 1.

Expected Behavior

The deploy is successful

Actual Behavior

The deploy fails

mcansh commented 7 months ago

change package-lock.json usages in the dockerfile to bun.lockb and update npm i usage to bun i and it should be good to go

justin-hackin commented 7 months ago

Okay I see that the init script detects package manager, whoops, thanks