search

remix-run / react-router-website

The React Router website
https://reactrouter.com
MIT License
149 stars 33 forks source link

Fix overlapping issue #107

Closed louis-smit closed 2 months ago

louis-smit commented 2 months ago

I managed to fix the element overlapping issue (#106), but because I needed to change some elements from block to flex it required some other changes like removing all the ml-72s and adjusting the padding. The Remix website source helped a lot on how to do this, and most of these changes come directly from there.

The footer is also slightly different due to the change from block to flex, so no problem if this is not merged because of that. Closest I could get it to working with flex instead of block :)

brookslybrand commented 2 months ago

Awesome, thank you @louis-smit!

I won’t be able to review for about a week, just FYI. I really appreciate you putting up this PR. From a cursory glance it seems good

louis-smit commented 2 months ago

Enjoy your PTO!