Open pveyes opened 1 day ago
Latest commit: 63a7d74bd76fbe2965f3616f0fc60b49230316ca
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @pveyes,
Welcome, and thank you for contributing to React Router!
Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.
You may review the CLA and sign it by adding your name to contributors.yml.
Once the CLA is signed, the CLA Signed
label will be added to the pull request.
If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.
Thanks!
- The Remix team
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳
Fix https://github.com/remix-run/react-router/issues/12335
I don't think we ever need a
Response
type here so we can just exclude them fromCreateLoaderData
andCreateActionData
. Not sure what tests to add because it's a type change