remix-run / react-router

Declarative routing for React
https://reactrouter.com
MIT License
53.25k stars 10.32k forks source link

Exclude Response from loader & action types #12376

Open pveyes opened 1 day ago

pveyes commented 1 day ago

Fix https://github.com/remix-run/react-router/issues/12335

I don't think we ever need a Response type here so we can just exclude them from CreateLoaderData and CreateActionData. Not sure what tests to add because it's a type change

changeset-bot[bot] commented 1 day ago

⚠️ No Changeset found

Latest commit: 63a7d74bd76fbe2965f3616f0fc60b49230316ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

remix-cla-bot[bot] commented 1 day ago

Hi @pveyes,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

remix-cla-bot[bot] commented 1 day ago

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳