Open PierreBerger opened 9 months ago
Hey @PierreBerger, thanks so much for taking the initiative to add this!
Would you left align the options and give a little more spacing? The example in the issue shows the inspiration from shadcn/ui
Hey @brookslybrand I've updated the dropdown position, let me know if it's ok for you.
Hey @PierreBerger sorry, I meant the options should be left aligned too. I do like where you positioned jt
I hope we are good now 😅
Hey @PierreBerger, I went ahead and pushed up a number of changes based on what I was trying to get at. Will you look over them and see if they make sense to you? There are a couple of TODOs left in there, if you want you're welcome to take a crack at them.
Please don't hesitate to ask if something isn't clear
Alright @PierreBerger, I've gone ahead and cleaned up the a11y issue and some of the css stuff I wanted to be a bit different. Will you review it and let me know what you think?
I thin the only thing that remains is adding a test to transformNpmCommand
. Additionally, would you just put that function inside app/ui/resources
?
Hey @brookslybrand, thanks for the help. I'm sorry, I'm quite busy at the moment. I will work on this next week.
Hey @brookslybrand, thanks for the help. I'm sorry, I'm quite busy at the moment. I will work on this next week.
All good! Really no rush on my part, just wanted to make sure I wasn't blocking you
This PR adds the ability to select the package manager (npm/yarn/pnpm/bun) when copying installation commands from the resources page.
Maybe I should add a test for the
transformNpmCommand
function?I've used
DetailsMenu
component for the Dropdown menu logic.Close #144