remix-run / remix-website

347 stars 79 forks source link

feat(resources): add ability to choose package manager #173

Open PierreBerger opened 9 months ago

PierreBerger commented 9 months ago

This PR adds the ability to select the package manager (npm/yarn/pnpm/bun) when copying installation commands from the resources page.

Maybe I should add a test for the transformNpmCommand function?

Capture d’écran 2024-02-03 à 19 01 51

I've used DetailsMenu component for the Dropdown menu logic.

Close #144

brookslybrand commented 9 months ago

Hey @PierreBerger, thanks so much for taking the initiative to add this!

Would you left align the options and give a little more spacing? The example in the issue shows the inspiration from shadcn/ui

PierreBerger commented 9 months ago

Hey @brookslybrand I've updated the dropdown position, let me know if it's ok for you.

Kapture 2024-02-08 at 21 47 40

brookslybrand commented 9 months ago

Hey @PierreBerger sorry, I meant the options should be left aligned too. I do like where you positioned jt

image

PierreBerger commented 9 months ago

Capture d’écran 2024-02-09 à 17 52 00

I hope we are good now 😅

brookslybrand commented 8 months ago

Hey @PierreBerger, I went ahead and pushed up a number of changes based on what I was trying to get at. Will you look over them and see if they make sense to you? There are a couple of TODOs left in there, if you want you're welcome to take a crack at them.

Please don't hesitate to ask if something isn't clear

brookslybrand commented 8 months ago

Alright @PierreBerger, I've gone ahead and cleaned up the a11y issue and some of the css stuff I wanted to be a bit different. Will you review it and let me know what you think?

I thin the only thing that remains is adding a test to transformNpmCommand. Additionally, would you just put that function inside app/ui/resources?

PierreBerger commented 8 months ago

Hey @brookslybrand, thanks for the help. I'm sorry, I'm quite busy at the moment. I will work on this next week.

brookslybrand commented 8 months ago

Hey @brookslybrand, thanks for the help. I'm sorry, I'm quite busy at the moment. I will work on this next week.

All good! Really no rush on my part, just wanted to make sure I wasn't blocking you