remix-run / remix-website

327 stars 74 forks source link

Cleanup meta tags #196

Closed Kazuhiro-Mimaki closed 6 months ago

Kazuhiro-Mimaki commented 6 months ago

In this PR, I define the function returning meta tags with some defaults.

Related

brookslybrand commented 6 months ago

Thanks @Kazuhiro-Mimaki for taking on adding this utility 🤘

I realize you pretty much just copied my example, which is a fine start. That wasn't meant to be the final implementation. Would you be interested in making the following adjustments?

Thanks again for taking this on!

Kazuhiro-Mimaki commented 6 months ago

Thanks @brookslybrand for comments.

I implement.

brookslybrand commented 6 months ago

YES! This is exactly what I wanting, thank you @Kazuhiro-Mimaki 🙏

Probably some improvements we can keep making, like adding a default image, or logic on the twitter:card value of summary vs summary_large_image, but honestly that's all pretty small stuff to me. For the most part, I imagine we will want to just do the default image with summary_large_image anyway