Closed dendrobiummoniliforme closed 6 months ago
Gathering info:
Which seemed to want to bring the pages more inline with React Router https://reactrouter.com/en/main which when a user right clicks on the React Router website logo they do get directed to https://reactrouter.com/brand which is a webpage dedicated to assets. It is not a google drive but my original thought about its usage seems correct.
Page is https://github.com/remix-run/react-router-website/blob/4b2bee1a7160d3de79b3f623aa0c5239e0f61ad9/app/routes/brand.tsx#L13 for the react-router-website
I guess the questions is:
Hi @dendrobiummoniliforme, thanks for bringing this up. This is in fact expected behavior. I'm not sure where we took this from, but I've seen it done on many websites. Here is Astro for example:
https://github.com/remix-run/remix-website/assets/12396812/1b6cb21d-5cab-4fd2-aa60-cc89198bda5e
While I agree we can probably give a slightly better experience than ripping you our site's context and into Google Drive, we do prefer to send you to all of the official, high quality assets if you're attempting to copy the logo.
So to your question
Should this instead link to a brand route much like the React Router page?
I think that could be cool! If this is something you're interested in taking on feel free to explore it, otherwise I can open a new issue with a more direct ask/mockup.
I posted that and then just realized that you've already opened up #199 😅
Thanks for doing that 🤘 I'll take a look today or tomorrow and provide any feedback
@brookslybrand I think this is good to close 😄 as per #199
Yep! Thanks for bringing this up and all your help @dendrobiummoniliforme :) The team is excited to have this page
Reproduction
System Info
Expected Behavior
OS / Web. Browser Specific context menu appears.
Actual Behavior
User redirected to google drive folder containing logos.
I'll note that if this is expected, that is fine. Have not seen this before, but I could understand a use-case such as: