search

remix-run / remix-website

327 stars 74 forks source link

Feature: Add Brand Page to Remix Website #199

Closed dendrobiummoniliforme closed 6 months ago

dendrobiummoniliforme commented 6 months ago

Summary

This is a copy of the React Router Brand page added in https://github.com/remix-run/react-router-website/commit/1fda7a162594425459d99f5e6998b18c220bd993

Changes

Motivation

dendrobiummoniliforme commented 6 months ago

Thanks @dendrobiummoniliforme! I haven't looked over the code extensively, but I did pull down the code and ran locally. Looks like it mostly just needs a bit of a face lift as it's pretty unstyled right now. Let me know if you need a bit more direction on this, I'm happy to provide it 🙂

@brookslybrand Thank you for taking a look! I think yes, I'll need a bit more direction on the styling, and if there is anything else to add/remove let me know :)

brookslybrand commented 6 months ago

Hey @dendrobiummoniliforme I went ahead and styled it a bit

I'm checking with the rest of the team if they have any reason not to go forward with this. We would of course need to add the colorful logos as well if we go forward

dendrobiummoniliforme commented 6 months ago

Hey @dendrobiummoniliforme I went ahead and styled it a bit

I'm checking with the rest of the team if they have any reason not to go forward with this. We would of course need to add the colorful logos as well if we go forward

Awesome! Thanks so much for this. I have gone ahead and added the glowing logo as well. Need to upload the asset as well. But otherwise I believe it is ready to go once the raw assets are added.

dendrobiummoniliforme commented 6 months ago

Alright assets added! Ready to go.

brookslybrand commented 6 months ago

@dendrobiummoniliforme this looks good to me! I tweaked a couple of things per my last 2 commits

I'm planning to deploy tomorrow morning (US CT). Let me know if there's any reason not to 🙂

kiliman commented 6 months ago

Looks really nice! Great work.

dendrobiummoniliforme commented 6 months ago

@dendrobiummoniliforme this looks good to me! I tweaked a couple of things per my last 2 commits

I'm planning to deploy tomorrow morning (US CT). Let me know if there's any reason not to 🙂

Thanks! And thank you for adding those final changes, didn't have much time over the weekend :)

Really enjoyed this process, thank you for all of your help.