Arisa/i18n article - Githubissues

remix-run / remix-website

327 stars 74 forks source link

Arisa/i18n article #201

Closed schabibi1 closed 6 months ago

schabibi1 commented 6 months ago

What's included in this PR:

[x] i18n guest article data/posts/remix-i18n.md
[x] Author headshot image public/authors/profile-arisa-fukuzaki.png
[x] Author info data/authors.yml
[x] Article-related images

Before publishing (@brookslybrand todo):

[x] Compress images
[x] Update date

brookslybrand commented 6 months ago

Thanks @schabibi1! Sorry I've been a bit delayed reviewing this. I just skimmed through and this is looking awesome 🎉

I'm really excited to get this merged in. I went ahead and deployed to staging (this is a shared environment, so link may not be stable). I also let the team know in case they want to review/give any feedback as well 🙂

We may get this merged in but delay the release a bit, just because we recently released the Vite announcement. I'll be sure to give you a heads up whenever it's going to be officially released.

schabibi1 commented 6 months ago

Hi @brookslybrand 👋 No worries! I'm so glad to have a review from you. The preview from the deployed staging looks good! I asked my team at Storyblok to let us know if they spot something at the Storyblok part in the article. But as I already wrote and published similar content in the referenced article, there shouldn't be ;)

All good from my side for when to publish this article, and let me update the change you requested.