remix-run / remix-website

327 stars 74 forks source link

Add background color to __mutation_code class #204

Closed brookslybrand closed 6 months ago

brookslybrand commented 6 months ago

While improving the styles to the site in #127 this line was removed. This made all of the codeblocks on the docs look a little nicer.

However, it broke a bit of the home page experience toward the bottom:

incorrect overlay of text on top of text

Simply adding this style to the __mutation_code class fixed the problem.

Personally, I think removing as much from the remark/shiki parsing as we can is probably a good thing. In pretty much all other cases we selected the pre tag directly.

At some point I would really love to go through all the styling on the website and unify it a bit more, since right now there's not a completely cohesive look and feel. It's fine, but it could be much better.