This issue can definitely be broken into multiple PRs, no need to try to migrate all of the places all at once. In fact, it will be much easier for me to review if it is broken up over a few PRs.
Be sure check that the meta tags look the same before and after the change, and that new tags are only introduced when it makes sense (for example, returning meta for a 404 probably shouldn't include <meta name="twitter:card" content="summary_large_image">
@Kazuhiro-Mimaki added a
getMetafunction in #196 which makes it much easier to add meta tags to various pages.This function should also make it much easier to remove
@remix-run/v1-metausage and lean fully into the v2 conventionThere are 20 places we use the
metaV1.This issue can definitely be broken into multiple PRs, no need to try to migrate all of the places all at once. In fact, it will be much easier for me to review if it is broken up over a few PRs.
Be sure check that the meta tags look the same before and after the change, and that new tags are only introduced when it makes sense (for example, returning meta for a 404 probably shouldn't include
<meta name="twitter:card" content="summary_large_image">