search

remix-run / remix-website

322 stars 72 forks source link

Fix Overlapping Scroll in Docs Page Between Header and Elements #242

Closed chialuka closed 3 months ago

chialuka commented 4 months ago

This PR fixes the overlap between elements when scrolling on the docs page. Here's how it looks now:

https://github.com/remix-run/remix-website/assets/42539315/ae9e2e74-fbbf-4d7d-920c-5d098332eb57

Closes #239

brookslybrand commented 4 months ago

Hey thanks so much @chialuka for opening up a PR for this

Unfortunately this ties the side nav and the main body to the same scroll, when they really should have 2 separate scroll areas like it is on remix.run right now

https://github.com/remix-run/remix-website/assets/12396812/1bbe0610-81fa-4d86-b8e9-2b0214195530

brookslybrand commented 4 months ago

@chialuka I went ahead and implemented this in #253. Thank you so much for taking a stab at it! This was a useful reference as I worked on a solution that hit all the corner-cases I was concerned about

chialuka commented 4 months ago

@chialuka I went ahead and implemented this in #253. Thank you so much for taking a stab at it! This was a useful reference as I worked on a solution that hit all the corner-cases I was concerned about

@brookslybrand, I'm so sorry I got tied down with work and couldn't get to this. I was hoping I'd do it over the weekend. I'll take a stab at another PR and hope I can contribute to the project

brookslybrand commented 3 months ago

Fixed in #253

Thanks again @chialuka for the initial work here 🙏