remix-run / remix-website

322 stars 72 forks source link

refactor: replace tailwind-extras.html with safelist feature #261

Closed kisaragi-hiu closed 2 months ago

kisaragi-hiu commented 3 months ago

this is silly, but our docs have some tailwind classes so I've copied them here so that in CI tailwind will add the right classes, gonna think of something better but I'm really tired and just want to ship this ...

Tailwind has safelist for this purpose (forcing classes to be generated no matter what) and can be used instead of a quick workaround. Hopefully this is something better.

I rewrote the comment like this:

docs have some tailwind classes, tell tailwind to always add these classes so the right classes are still added in CI

which should hopefully still adequately explain the intent of safelisting these classes.

brookslybrand commented 2 months ago

Resolved in #276

Thanks for pointing this issue out!