search

remix-run / remix-website

322 stars 72 forks source link

Bump to pre-release and turn on fog of war #275

Closed brookslybrand closed 2 months ago

brookslybrand commented 2 months ago

There are a couple of bugs we need to fix first (Monday), so don't merge this

brookslybrand commented 2 months ago

@brophdawg11 is it expected that we're logging the GET requests for the manfiest? Seems like this could get pretty noisy 😅

Screenshot 2024-06-15 at 8 46 09 AM
machour commented 2 months ago

Also, isn't there a hard browser limit for GET queries path length ? 😅

brophdawg11 commented 2 months ago

The logging is part of the built in app.use(morgan("tiny")) logging - we can filter that out in our server.mjs file for /__manifest URLs.

Yeah - the limit is ~8k which I thought was sufficient but this Remix docs site which is heavy on links with the sidebar is already around 7k so we'll probably need to switch to a POST. Maybe we can do this conditionally - since we want to be able to leverage caching on __manifest calls when possible. I expect that URLs over the 8k limit will be the exception, not the norm.

brookslybrand commented 2 months ago

The logging is part of the built in app.use(morgan("tiny")) logging - we can filter that out in our server.mjs file for /__manifest URLs.

Ah perfect, yeah I should have checked for that, thanks Matt