Closed brookslybrand closed 2 months ago
@brophdawg11 is it expected that we're logging the GET requests for the manfiest? Seems like this could get pretty noisy 😅
Also, isn't there a hard browser limit for GET queries path length ? 😅
The logging is part of the built in app.use(morgan("tiny"))
logging - we can filter that out in our server.mjs
file for /__manifest
URLs.
Yeah - the limit is ~8k which I thought was sufficient but this Remix docs site which is heavy on links with the sidebar is already around 7k so we'll probably need to switch to a POST. Maybe we can do this conditionally - since we want to be able to leverage caching on __manifest
calls when possible. I expect that URLs over the 8k limit will be the exception, not the norm.
The logging is part of the built in app.use(morgan("tiny")) logging - we can filter that out in our server.mjs file for /__manifest URLs.
Ah perfect, yeah I should have checked for that, thanks Matt
There are a couple of bugs we need to fix first (Monday), so don't merge this