remix-run / remix

Build Better Websites. Create modern, resilient user experiences with web fundamentals.
https://remix.run
MIT License
28.55k stars 2.41k forks source link

Vulnerability detected in library Braces #9215

Open Amousy opened 3 months ago

Amousy commented 3 months ago

Reproduction

Run checkmarx scan

System Info

Cxab55612e-3a56 | Uncontrolled resource consumption

Used Package Manager

yarn

Expected Behavior

Scan without any error.

Actual Behavior

SCA Alerts: The NPM package "braces" fails to limit the number of characters it can handle, which could lead to Memory Exhaustion. In "lib/parse.js," if a malicious user sends "imbalanced braces" as input, the parsing will enter a loop, which will cause the program to start allocating heap memory without freeing it at any moment of the loop. Eventually, the JavaScript heap limit is reached, and the program will crash.

More details: https://devhub.checkmarx.com/cve-details/Cxab55612e-3a56/

Amousy commented 1 month ago

Hello, Upgrading to the latest version 3.0.3 should fix this issue.

Btw, it would be interesting to activate Dependabot to help you automate the updating of dependencies with security vulnerabilities.

Regards.