Handle hours resetting at midnight

remix / partridge

A fast, forgiving GTFS reader built on pandas DataFrames

https://partridge.readthedocs.io

MIT License

151 stars 22 forks source link

Handle hours resetting at midnight #42

Closed genhernandez closed 5 years ago

genhernandez commented 6 years ago

partridge version: 0.11.0
Python version: 3.6

Description

Seen in Singapore GTFS.

Times go ["23:56:00", "00:02:00"...], and ideally times would be normalized to ["23:56:00", "24:02:00"...].

However, I'm not sure how prevalent this problem is. Any thoughts?

invisiblefunnel commented 6 years ago

@genhernandez thanks for posting this issue. I know we've seen it at Remix a few times.

Has anyone else out there run into this issue? How did you solve it?

tilgovi commented 5 years ago

Related (or maybe the same issue) is that GTFS specifies that times are seconds since noon minus 12 hours. For calendar days when there is a daylight savings shift, the float representation of the parsed time is currently incorrect.

invisiblefunnel commented 5 years ago

Closing due to lack of interest. @tilgovi I made your comment a new issue.