Closed baudev closed 6 years ago
Please fix tests @baudev
Test passed on Node v6 ! https://travis-ci.org/remixz/messenger-bot/jobs/385714367
What about Node4? I have not setup these pipelines so I'm not sure I can make changes to those. Maybe @remixz can.
The mentioned errors in Node4 don't seem to be related to my MR.
EDIT : Sorry for closing the MR. Mistake on my part.
The function could be used as following finally :
bot.sendMessage(payload.sender.id, {"text": "message_test"}, (error, body) => {
// ...
}, 'MESSAGE_TAG', 'NON_PROMOTIONAL_SUBSCRIPTION');
This issue's comment https://github.com/istanbuljs/nyc/issues/865#issuecomment-398435383 explains that node 4.x
is no more supported with the latest versions of nyc
. This is confirmed by the following commit: https://github.com/istanbuljs/nyc/commit/19b7d2130556b939bdd2fb69c2a35d09fe83f61e
We have two options:
node 4.x
and then this test in Travisnyc
. As nyc
is a dependency of tap
we should specify the version of the latter.I prefer the last solution: easier and more secure. Then it requires that @remixz remove the node 4
test in his Travis account.
What do you think about @eXeDK ?
I tried everything. I think that specifying the tap
version doesn't work due to the Travis cache. Anyway.
@remixz should remove the Node4
test or maybe @eXeDK have the rights of editing/remove/add tests ?
I think I have some access to the travis-ci setup as well. I'll try and remove the Node4
I'll merge this and try and fix the tests afterwards @baudev
Add the function
sendMessageWithTag(recipient, payload, tag, cb)
which allows sending messages with the specified tag.Example of usage :