search

remixz / messenger-bot

A Node client for the Facebook Messenger Platform
MIT License
1.09k stars 213 forks source link

Add doc for linking account listeners #92

Closed baudev closed 6 years ago

baudev commented 6 years ago

Add documentation for the two following listeners:

baudev commented 6 years ago

Thanks for merging this PR @eXeDK ! Can you please update the tag v2.4.0 or consider adding a new one? Because the current one v2.4.0 goes back to 17 Oct 2016...

eXeDK commented 6 years ago

Yep sure thing! I'll have a look at in the weekend @baudev

baudev commented 6 years ago

@eXeDK When you have a little time, if you could think about it please! There's no hurry.

eXeDK commented 6 years ago

I'm looking at bumping the graph api from 2.6 to 2.7 just for a very quick fix before the API is deprecated. Then I think we should include it all in a v2.5.0.

Then do a more complete rewrite with the newest APIs afterwards. What are your thoughts on that @baudev ?

baudev commented 6 years ago

Sorry I restored my branch by error. I confused with the PR https://github.com/remixz/messenger-bot/pull/91.

Indeed, we should update the graph API for the v2.5.0. But why updating to the 2.7 and not directly to the 3.0?

eXeDK commented 6 years ago

I ended up updating to 2.12 instead. I didn't want to bump to a new major version with my limited time. Version 2.12 is supported till 2020.

I also thought about the future life of this package. Is there still a need for this package? I see some more generic and more up to date packages out there now like: https://github.com/howdyai/botkit

Would it make more sense to point users to botkit instead?

baudev commented 6 years ago

I ended up updating to 2.12 instead

Perfect then! You can consequently release the v2.5.0?

Otherwise I think there is still an interest for this package. It's why I started contributing on it! This repository:

eXeDK commented 6 years ago

I already did on Sunday actually :-) https://www.npmjs.com/package/messenger-bot

Fair enough, then I'll help maintaining it as well.

baudev commented 6 years ago

Perfect thanks! I was only checking tags 😅

Fair enough, then I'll help maintaining it as well.

That's a good news to hear that!

eXeDK commented 6 years ago

Ahh sorry, forgot to push the tag :D I created a new release as well