remixz / umi

📺 Watch Crunchyroll together, and more
https://umi.party
127 stars 24 forks source link

WIP dark theme #14

Open yowkah opened 6 years ago

yowkah commented 6 years ago

the theme switch can be found in the settings page.

At the moment I just painted most of the things on screen black or dark-gray. I also changed some existing styles to better fit the transformation.

At the moment I think it would be better to just refactor the classnames. So that instead of referring to bg-white it would be bg-primary and bg-near-white to bg-offset.

overwriting styles using a "dark" class on the root element and changing the component CSS files seems like a more attractive option after changing that.

remixz commented 6 years ago

This is looking very good so far! 🎉 My one request would be to make any text that's gray into near-white, as it has more contrast and is easier to read.

I am good with the idea of refactoring the classes so we have our own colour classes like bg-primary and such, instead of only using Tachyon's colours. In reality, the reason I just used Tachyon's colours is out of laziness. 😂

remixz commented 6 years ago

I will likely play with some of the colours after this is finished, so you don't need to worry about them being perfect. Of course, play with whatever you think looks good. 😂 If you can get the dark theme mostly there, especially with the refactoring of the classes, that would be extremely helpful and appreciated!