search

remixz / umi

📺 Watch Crunchyroll together, and more
https://umi.party
127 stars 24 forks source link

FIX: Session destroyed on page refresh #59

Closed yowkah closed 2 years ago

yowkah commented 2 years ago

Related to #50 . It seems that the Token is not always given with authentication. Absence of the token should not be valid reason to terminate or remove a perfectly good session.

remixz commented 2 years ago

Thank you for fixing this! (And sorry for the delayed response.) There's one more fix as well needed, which is to not clear the auth token if it's null. I created a patch to do so here: https://github.com/remixz/umi/commit/47c94adcb58512962b1b022b7bfc7e2c065ba22b I'm going to open a PR with your patch and mine, and merge that in. Thank you again!!

remixz commented 2 years ago

New PR: https://github.com/remixz/umi/pull/60 (with your commit left in tact, so you get proper credit 😄 )