remkus / fortytwo

FortyTwo base Genesis Child theme for Forsite Themes
1 stars 0 forks source link

FortyTwo Theme #2

Closed ryanholder closed 11 years ago

ryanholder commented 11 years ago

Initial Thoughts.

So FortyTwo is a theme that we wan't people to use as the base theme for development work. I still believe that we will have a base version for the following;

We stick to those four but initially all focus and launch is that it will be just the business theme.

We have decided that we will wait on HTML5 integration from Genesis before tackling this area.

We have now decided that the theme will have Bootstrap integration and those elements are to be discussed but further below I have mentioned what portions of forty two should be bootstrap.

Also something I would like to see is that you log in to your account on Forsite which you will have once you purchase the theme and in your account area is the customiser which allows you to set the basics of your fortytwo theme and then download the theme, just like Bootstrap Customiser

We can use the same code that bootstrap uses for the customiser.

Bootstrap Elements in Genesis

ND: My initial thinking around bootstrap integration was to try and provide for it without ever changing the html structure of Genesis. This solution just seems to be the wrong course of action. Instead I feel that the choice of solution needs to be measured against the task required with the following in mind;

  • We first attempt to use current classes as a holder for the Bootstrap classes, if this proves even slightly tricky we move on...
  • We need to be able to add css classes in our desired locations to take on Bootstrap styling and it needs to be achieved by some available filter etc.
  • If we cannot achieve the desired result we then make a decision on the value of the feature vs altering standard structure.

    Fluid & Responsive

These are 2 different items but part of the same solution around making the theme work across multiple devices. I have created a separate issue around this item to allow for more specific conversation around achieving this. https://github.com/forsitethemes/forty-two/issues/3

Bootstrap Base CSS

All items mentioned on the Bootstrap Base CSS should not be an issue to implement. The 3 main items for now is the typography, buttons and forms and all of these should be in place by the standard inclusion of bootstrap and by utilising specific classes when implementing features. For example anytime we add a button we make sure we have a .btn class or in the case of the address widget we can use <address> tag.

This is an area that requires some more discussion. We have still not finalised if in order to have Bootstrap styled navigation in the theme you need to have the sizzle pack enabled. Sizzle pack menus provides bootstrap styled nab with the ability to have widgets in the nav, is this the only way to get bootstrap nav ?

The structure required by Bootstrap is the same as Genesis requires however we will ned to investigate adding in the required css classes.

Although not a major feature on a site, Bootstrap does a fantastic job with some classes to easily alter the layout and design.

Bootstrap Media Object

This is an area to investigate for the handling of blog comments. I would imagine that it would involve quite a change to the way genesis lays out comments but I like the code in Bootstrap.

remkus commented 11 years ago

We have decided that we will wait on HTML5 integration from Genesis before tackling this area.

We can still use an HTML5 markup like I'm doing on the WP Realm theme or even a slimmed down version of that.

All items mentioned on the Bootstrap Base CSS should not be an issue to implement.

What are we going to do with Bootstrap's ever changing version? There's a 3.0 version on the way ...

Also something I would like to see is that you log in to your account on Forsite which you will have once you purchase the theme and in your account area is the customiser which allows you to set the basics of your fortytwo theme and then download the theme, just like Bootstrap Customiser

We can also find inspiration in Underscores.me in how they let you download a version of their theme with a few things already set (such as theme name and such).

mrdavidlaing commented 11 years ago

Also something I would like to see is that you log in to your account on Forsite which you will have once you purchase the theme and in your account area is the customiser which allows you to set the basics of your fortytwo theme and then download the theme, just like Bootstrap Customiser

Great idea; but I believe out of scope for initial launch.

mrdavidlaing commented 11 years ago

Bootstrap Navbar

This is an area that requires some more discussion. We have still not finalised if in order to have Bootstrap styled navigation in the theme you need to have the sizzle pack enabled. Sizzle pack menus provides bootstrap styled nab with the ability to have widgets in the nav, is this the only way to get bootstrap nav ?

I think we should require sizzle-pack to be installed in order to use the theme.

BUT; I think the theme should be bundled with a "dependancy checker", which checks that required dependancies are in place before theme activation, and guides you through installing those that aren't there already.

mrdavidlaing commented 11 years ago

http://tgmpluginactivation.com/

ryanholder commented 11 years ago

This issue/ticket is no longer valid. We understand what FortyTwo is going to evolve in to and we have dealt with HTML5 and BS integration