search

remnoteio / remnote-official-plugins

22 stars 10 forks source link

Can't close the tab #15

Closed FriesenAndreas closed 2 years ago

FriesenAndreas commented 2 years ago

Hi, I'm using Remnote with the Plugin "Tabs" it's a nice feature, but I can't close any tab. If I press the "x" nothing happened.

Please check!

Regards Andreas

GitMurf commented 2 years ago

Yep I am having the same issue. Note that you can go to the workspace power up (see it in the References at bottom of any Rem page) and can delete the Rem for the tab and it will then "close" the Tab :) This is a workaround for now that I have found.

bjsi commented 2 years ago

Hmmm I tried to repro the other day and couldn't, I'll try again now

bjsi commented 2 years ago

Found the issue - only happens in native mode - as a workaround you can use the plugin in sandboxed mode until the fix is released

GitMurf commented 2 years ago

I was actually curious about this... for this plugin what is the difference between native and sandboxed?

GitMurf commented 2 years ago

Also I can confirm that with native mode turned off it does indeed work :)

bjsi commented 2 years ago

I was actually curious about this... for this plugin what is the difference between native and sandboxed?

When a plugin is sandboxed it runs inside an iframe, when it is native, we basically just eval() the plugin code so it runs in the main thread. Sandboxed == higher security, native == higher performance. As this is a plugin built by the team, we made it native by default.

The fix is merged, will be deployed soon