search

remobjects / pascalscript

pascalscript
Other
447 stars 178 forks source link

1)InvokeCall added, instead of all different … #207

Closed Vizit0r closed 5 years ago

Vizit0r commented 5 years ago

...callers (x86, x64, powerpc etc) for Delphi 2010+.

Tested on Win x86&x64, Android, MacOS32 - no problems observed.

2) Changes for correct MACOS compilation in Delphi

3) few changes and fixes for correct PS work on D7.

Vizit0r commented 5 years ago

so, Carlo?

next pack awaiting :)

martijnlaan commented 4 years ago

@carlokok @Vizit0r and others:

Ever since this pull request got merged it seems that ROPS has gotten unstable. There have been quite some issues reported with it, some with merged fixes (#211, #213) but also some without merged fixes (#217, #218, #219). Now I don't really know if it's safe to update anymore and am considering to create a personal fork at 1f846a56c81997b5cafe20d8dbd2234a88314a63, which is the commit before @Vizit0r's two big merged pull requests (this one and #205).

In hindsight, were these pull requests worth it? If not, would it be better to revert them?

It doesn't help that both pull requests contain various different and unrelated changes, making it much harder to check things.

martijnlaan commented 4 years ago

@Vizit0r @carlokok I talked to Carlo and as he suggested added a PS_USECLASSICINVOKE which makes it possible to avoid InvokeCall.inc but this still leaves a bunch of unexplained changes. For example in #205 I count 4 unexplained changes.

Vizit0r commented 4 years ago

sorry gentlemens, i've been on work last 3,5 month with internet speed near zero. Will read, analyze and answer soon.