search

remodoy / clj-postgresql

PostgreSQL helpers for Clojure projects
BSD 2-Clause "Simplified" License
161 stars 17 forks source link

Remove org.slf4j/slf4j-simple from dependencies #1

Closed DrTom closed 10 years ago

DrTom commented 10 years ago

Could you remove org.slf4j/slf4j-simple from the dependencies, respectively move it to dev dependencies. Requiring a logging implementation in a library gets a bit nasty if a user is using a different logging framework. The slf4j manual has some rational about this http://www.slf4j.org/manual.html.

There is a workaround [clj-postgresql "0.3.0-SNAPSHOT" :exclusions [org.slf4j/slf4j-simple]], but well ...

jkjuopperi commented 10 years ago

Quite right! Changed slf4j-simple dependency to slf4j-api and added slf4j-simple to dev dependencies. Fixed in commit 567a2ada74db11a054f844fe6b7b86579c7cb85d

jkjuopperi commented 10 years ago

Sigh. Still learning to use github issues properly. Fixed nevertheless.