remorses / bump-version

Action to bump version files
36 stars 12 forks source link

Chore/cleanup #15

Closed ANGkeith closed 3 years ago

ANGkeith commented 3 years ago
remorses commented 3 years ago

You cannot delete node_modules because github actions need all the code to run in the repo

ANGkeith commented 3 years ago

ok. my bad, did'nt know that

ANGkeith commented 3 years ago

by the way, @remorses what about the typescript version?

npx tsc failed to compile in a clean repo, and got the following error:

$ npx tsc 
src/createTag.ts:20:48 - error TS1109: Expression expected.

20     const repo = process.env.GITHUB_REPOSITORY?.split('/').pop() as string
                                                  ~

src/createTag.ts:22:5 - error TS1005: ':' expected.

22     const tags = await git.repos.listTags({
       ~~~~~

src/main.ts:40:24 - error TS1109: Expression expected.

40         preReleaseTag ?? undefined,
                          ~

src/main.ts:40:35 - error TS1005: ':' expected.

40         preReleaseTag ?? undefined,
                                     ~

Found 4 errors.

i am only managed to regenerate the same js with 4.0.8