search

remotemobprogramming / mob

Tool for smooth git handover.
https://mob.sh
MIT License
1.66k stars 149 forks source link

Use mp3/ogg files instead of voice command #203

Open jochenchrist opened 2 years ago

jochenchrist commented 2 years ago

Voice engines are a hassle, esp under Windows and Linux. Just use mp3 or OGG files.

https://github.com/faiface/beep looks promising for this.

simonharrer commented 2 years ago

Beep is based on https://github.com/hajimehoshi/oto which requires some other software that may need to be installed by the user manually.

lizell commented 2 years ago

I implemented this for Macs at https://github.com/lizell/mob

Just go

mob install-custom-next file.ogg

or

mob install-custom-next install-custom-next https://file-examples-com.github.io/uploads/2017/11/file_example_MP3_700KB.mp3

and it will be used instead of the voice engine

If you think it is a good idea I could try to add support for Windows and Linux and turn it into a PR?

simonharrer commented 2 years ago

Have a look at https://github.com/remotemobprogramming/mob/pull/235 for my try at it

hollesse commented 2 years ago

Why do you remove the configuration of the voice command? Don’t you think it makes sense to give the users the freedom to replace this command?

simonharrer commented 2 years ago

Behavior is not fully downwards compatible (see the replacing of %s with the voice message), it will break either way except when introducing yet another configuration option. So instead of adding another configuration option, I eliminated two already existing ones.

lizell commented 2 years ago

I just brought my fork up to date with the latest release. .mob as a user configuration file was added brekaing my original implementation. I added .mob as a dir where one could put configuration. I have changed that now. Here is an alternate PR #236 to #235.