search

remotemobprogramming / mob

Tool for smooth git handover.
https://mob.sh
MIT License
1.66k stars 149 forks source link

Open last modified file with spaces in path #388

Closed kriber82 closed 1 year ago

kriber82 commented 1 year ago

This is my attempt to allow opening last modified files when the project path on disk contains spaces. I also opened issue #387 with further details.

The test I added works with a last modified file containing spaces instead of a project path containing spaces, as this was way easier to set up for me and seems to exhibit the same behavior.

As I have no prior experience with Go, I assume my code is not idiomatic. Also, I have not yet extracted functions yet. Therefore, feedback about how my code better fits into the codebase is greatly appreciated.

hollesse commented 1 year ago

Hey @kriber82 thank you for your contribution and also the well described issue :) I will have a look at it later, when i have some time. But my first impression is, that it looks good :)

hollesse commented 1 year ago

closes #387

kriber82 commented 1 year ago

I will incorporate your feedback, when I find time, which will probably be sometime next week.

gregorriegler commented 1 year ago

Hi @kriber82 do you think you will find the time for making the improvements?

kriber82 commented 1 year ago

Sorry for the huge delay. Will try to do it within the next days.