search

remotemobprogramming / mob

Tool for smooth git handover.
https://mob.sh
MIT License
1.66k stars 149 forks source link

Exits with 0 on at least some failures #402

Closed mightyiam closed 4 months ago

mightyiam commented 8 months ago

Here's one: cannot start; clean working tree required

But exits with 0.

seanpoulter commented 6 months ago

It looks like we catch that err here but don't exit(1):

https://github.com/remotemobprogramming/mob/blob/211588323b167d9d584a23e900ddd534a5f8f4ba/mob.go#L309-L311

Would that be an appropriate change, or do we have a different plan to handle exit on error?

hollesse commented 6 months ago

Hi @seanpoulter exit(1) is the way to go! Would you like to create a pull request for that?

seanpoulter commented 6 months ago

I'm happy to make a PR @hollesse.