remotemobprogramming / timer

A team timer for mob.sh.
https://timer.mob.sh
MIT License
23 stars 4 forks source link

set last timer as new default #16

Closed hollesse closed 1 year ago

hollesse commented 1 year ago

fixes #9

gregorriegler commented 1 year ago

Ok, so it sets the default now. I don't understand if this is the behaviour simon wanted, but it looks good to me.

hollesse commented 1 year ago

That was what I understood from his answer on twitter. Is that what you meant @simonharrer ?

simonharrer commented 1 year ago

No, it was simply a statement that there are two concepts. Would not merge this in this state. Last value and custom value are two different concepts, and I don’t think mixing them is good. We either support both or focus on one. I think the custom value is more valuable as I can set the typcial value (we rotate after 8inutes) nd sometimes deviate from that. i don’t want to lose my typical value because of the one deviation, having to type the custom value in again.

gregorriegler commented 1 year ago

Ok, what would be an example you liked better

simonharrer commented 1 year ago

I know of no easy way that makes the UI more complicated. I just want my custom value, the fixed, usual, team agreed upon rotation time, to stay the same and not to be changed when I select another one for a special occasion.

hollesse commented 1 year ago

Should we then have an option to set default values for a room? But these would then be reset with every release. Or should we allow the users to set their default and save it in their local storage?

simonharrer commented 1 year ago

Again, not easy because some people create new rooms per feature whereas some always stay in their specific room. Habing a default value for a room is only helpful for a team that doesn’t change the room, and without persistence storage it just doesn’t work.

gregorriegler commented 1 year ago

@simonharrer one question: what is that special occasion, when you want to change the timer? Do you have an example? I'm asking because it sounds like what you want is more time, which a "Pause Button" could also solve.

simonharrer commented 1 year ago

Examples:

hollesse commented 1 year ago

As I understand your points it then could be a solution to alle the user to set his/her default value for the timer. The the user can use this timer regularly and if they need another timer use the drop-down. But that would not solve the need for custom timers. For that we could also add user specific settings

simonharrer commented 1 year ago

As I understand your points it then could be a solution to alle the user to set his/her default value for the timer. The the user can use this timer regularly and if they need another timer use the drop-down.

That is the currently implemented solution, with the "default" value configured on the web and stored in localStorage per user.

But that would not solve the need for custom timers. For that we could also add user specific settings

The question is: is there really a need for that? I haven't had that need in my coachings.

gregorriegler commented 1 year ago

What if we turn that 'increasing of the current timer' into a separated UI/UX concept.

So whenever a Timer is started and running, you can click and drag the current timer display, and it will change the time accordingly. So I forgot to start the timer, so I start it now, and then I click inside the timer display (while it already runs) and I drag it to the left. While I'm dragging, the timer visibly changes first to 9 minutes, then to 8, 7, 6, 5 and then I release my mouse button on 5, and the timer continues.

I think it would be cool. And it would solve our problem. However, people won't easily discover that feature by themselves.

simonharrer commented 1 year ago

Cool idea, but most people use the CLI anyway, so would be a huge invest for a feature only very very few people will use.