search

remotemobprogramming / timer

A team timer for mob.sh.
https://timer.mob.sh
MIT License
24 stars 4 forks source link

Allow uppercase letters and underscores in room URLs #6

Closed jkemming closed 2 years ago

jkemming commented 2 years ago

Hello,

I'd like to suggest a slight change to the room URL matching. In my team we occasionally run into problems where our mob timer room URLs result in 404 Not Found because they contain either uppercase letters or underscores. This is because we start our mob timers through the mob CLI (e.g. mob timer 10) and use something like MYPROJECT-123_some_change as our mob branch name. This can sometimes be a little irritating since the mob CLI itself does allow such mob names.

Regardless of whether you accept this minor suggestion, my team and I really enjoy the mob CLI and timer. Thank you for your work!

Also, should this kind of contribution be entirely undesired please let me know.

Kind regards

simonharrer commented 2 years ago

Thanks for the praise and the contribution. I think it makes sense, especially with the feature of using the --branch name as the room name to make the regex pattern less restrictive.

simonharrer commented 2 years ago

New version deployed. Happy collaborating! :-)