search

remoteoss / json-schema-form

https://json-schema-form.vercel.app
MIT License
70 stars 7 forks source link

feat(description) - Remove extra span in description, extra and statement #27

Closed gabrielseco closed 8 months ago

gabrielseco commented 1 year ago

1. Description

Remove extra span in the description, extra and statement parameters of the fields

2. How to test this

I've created an internal MR where you can test this.

gabrielseco commented 1 year ago

Let me know if you have time to review this PR this week

cc: @sandrina-p @brennj

brennj commented 1 year ago

Let me know if you have time to review this PR this week

cc: @sandrina-p @brennj

Probably not today, but should be good to look at this tomorrow morning~

gabrielseco commented 9 months ago

Applied the suggestions in this PR, I'll go now to dragon and check Sandrina's comments

brennj commented 9 months ago

This is awesome. @gabrielseco whenever you can, lets resolve the conflicts and merge this one.

gabrielseco commented 9 months ago

Resolved conflicts @brennj

This is awesome. @gabrielseco whenever you can, lets resolve the conflicts and merge this one.

gabrielseco commented 9 months ago

I notice I added a yarn lock, just remove it and added it to gitignore to not commit the same error twice