Closed brennj closed 10 months ago
Hopefully this is ready for another look and a merge 👀
Looks good from my perspective - appreciate the changes! One suggestion that Sandrina made about the name of the
jsonLogic
fixtures file is still outstanding, I believe?
i know i seen this before but i cant find it again
Looks good from my perspective - appreciate the changes! One suggestion that Sandrina made about the name of the
jsonLogic
fixtures file is still outstanding, I believe?i know i seen this before but i cant find it again
Sometimes it's easier to see all the comments from the Files changed
view in my experience.
This is a breakdown of https://github.com/remoteoss/json-schema-form/pull/28 to make it more digestible for review.
There will be multiple PRs:
x-jsf-logic-validations
. That is this PR.x-jsf-logic-computedAttrs
(with reference to values defined inx-jsf-logic.computedValues
) support.x-jsf-logic-computedAttrs
support.This PR:
json-schema-form
instance increateHeadlessForm.js